linux-kernel - [PATCH 4.16 16/43] usb: core: message: remove extra endianness conversion in usb_set_isoch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180614132135.897294932@linuxfoundation.org>
Date:   Thu, 14 Jun 2018 16:04:20 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org,
        Dmytro Panchenko <dmytro.panchenko@...ballogic.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Ruslan Bilovol <ruslan.bilovol@...il.com>
Subject: [PATCH 4.16 16/43] usb: core: message: remove extra endianness conversion in usb_set_isoch_delay

4.16-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Ruslan Bilovol <ruslan.bilovol@...il.com>

commit 48b73d0fa11aa8613d51f7be61d2fa7f0ab05fd3 upstream.

No need to do extra endianness conversion in
usb_set_isoch_delay because it is already done
in usb_control_msg()

Fixes: 886ee36e7205 ("usb: core: add support for USB_REQ_SET_ISOCH_DELAY")
Cc: Dmytro Panchenko <dmytro.panchenko@...ballogic.com>
Cc: Felipe Balbi <felipe.balbi@...ux.intel.com>
Cc: stable <stable@...r.kernel.org> # v4.16+
Signed-off-by: Ruslan Bilovol <ruslan.bilovol@...il.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
 drivers/usb/core/message.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -940,7 +940,7 @@ int usb_set_isoch_delay(struct usb_devic
 	return usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
 			USB_REQ_SET_ISOCH_DELAY,
 			USB_DIR_OUT | USB_TYPE_STANDARD | USB_RECIP_DEVICE,
-			cpu_to_le16(dev->hub_delay), 0, NULL, 0,
+			dev->hub_delay, 0, NULL, 0,
 			USB_CTRL_SET_TIMEOUT);
 }