linux-kernel - Re: [alsa-devel] [PATCH] ASoC: codecs: PCM1789: include gpio/consumer.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb-j4E8JL10i2-AQ4_ZWRu9NrMVaGJBbXwoFxufY60HUQ@mail.gmail.com>
Date:   Thu, 14 Jun 2018 16:44:38 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Mark Brown <broonie@...nel.org>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>, Liam Girdwood <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Mylène Josserand <mylene.josserand@...tlin.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: codecs: PCM1789: include gpio/consumer.h

On Wed, May 30, 2018 at 11:53 PM, Arnd Bergmann <arnd@...db.de> wrote:

> When CONFIG_GPIOLIB is disabled, this codec fails to build
> because gpio/consumer.h is not included implicitly.
>
> sound/soc/codecs/pcm1789.c: In function 'pcm1789_common_init':
> sound/soc/codecs/pcm1789.c:247:19: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_gpio_request_one'? [-Werror=implicit-function-declaration]
>   pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
>                    ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 4ae340d1be36 ("ASoC: codecs: Add support for PCM1789")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij