linux-kernel - Re: [PATCH] proc: Make inline name size calculation automatic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180614200956.GB7137@avx2>
Date:   Thu, 14 Jun 2018 23:09:56 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     dhowells@...hat.com
Cc:     viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] proc: Make inline name size calculation automatic

> Require a minimum inline name size of 33+1 to allow for names that look
> like two hex numbers with a dash between.

Hi, David.

Why 34? /proc will fallback to separate allocation for name anyway.

I sent nearly identical patch earlier.
https://marc.info/?l=linux-kernel&m=152667374404900&w=4

If you compare, the differences are:

* no BUILD_BUG_ON,
* 64 bytes is too litle even on 32-bit,
* 512 bytes is probably too much even on 64-bit.

> -	.name		= proc_root.inline_name,
> -	.inline_name	= "/proc",
> +	.name		= "/proc",

This will "uninline" 5 bytes wasting space.