linux-kernel - Re: [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b027a324-ffae-fd5e-d8a3-03934be91a2d@zytor.com>
Date:   Thu, 14 Jun 2018 13:47:27 -0700
From:   "H. Peter Anvin" <hpa@...or.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>,
        akpm@...ux-foundation.org, mingo@...hat.com, tglx@...utronix.de
Cc:     linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
        x86@...nel.org, virtualization@...ts.linux-foundation.org,
        astrachan@...gle.com, manojgupta@...gle.com, ghackmann@...gle.com,
        sedat.dilek@...il.com, tstellar@...hat.com, keescook@...gle.com,
        yamada.masahiro@...ionext.com, michal.lkml@...kovi.net,
        linux-kbuild@...r.kernel.org, geert@...ux-m68k.org,
        will.deacon@....com, mawilcox@...rosoft.com, arnd@...db.de,
        rientjes@...gle.com, acme@...hat.com, pombredanne@...b.com,
        aryabinin@...tuozzo.com, kstewart@...uxfoundation.org,
        boris.ostrovsky@...cle.com, jan.kiszka@...mens.com,
        rostedt@...dmis.org, kirill.shutemov@...ux.intel.com,
        ard.biesheuvel@...aro.org, akataria@...are.com,
        brijesh.singh@....com, caoj.fnst@...fujitsu.com,
        gregkh@...uxfoundation.org, jarkko.sakkinen@...ux.intel.com,
        jgross@...e.com, jpoimboe@...hat.com, mka@...omium.org,
        thomas.lendacky@....com, tweek@...gle.com, mjg59@...gle.com,
        joe@...ches.com, andrea.parri@...rulasolutions.com,
        "H. Peter Anvin" <hpa@...ux.intel.com>
Subject: Re: [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument
 registers to <asm/asm.h>

On 06/13/18 14:05, Nick Desaulniers wrote:
> From: "H. Peter Anvin" <hpa@...ux.intel.com>
> 
> i386 and x86-64 uses different registers for arguments; make them
> available so we don't have to #ifdef in the actual code.
> 
> Native size and specified size (q, l, w, b) versions are provided.
> 
> Suggested-by: Sedat Dilek <sedat.dilek@...il.com>
> Signed-off-by: H. Peter Anvin <hpa@...ux.intel.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>

I still object to Suggested-by: here.  Sedat did a correction, which is
a Reviewed-by:, but unless I'm completely out to sea, there was no
suggestion on Sedat's part of this; and I had certainly not seen it when
I wrote the code.

	-hpa