linux-kernel - Re: [PATCH] usb: don't offload isochronous urb completions to ksoftirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180614183546.7e04024c@gandalf.local.home>
Date:   Thu, 14 Jun 2018 18:35:46 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Mikulas Patocka <mpatocka@...hat.com>
Cc:     Alan Stern <stern@...land.harvard.edu>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ming Lei <ming.lei@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        USB list <linux-usb@...r.kernel.org>,
        Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: don't offload isochronous urb completions to
 ksoftirq

On Thu, 14 Jun 2018 18:23:11 -0400 (EDT)
Mikulas Patocka <mpatocka@...hat.com> wrote:

> I don't think it's so easy. The kernel 2.4 and below did this. And the 
> problem was that if there's a storm of network packets, the softirq code 
> would cause lockup of the whole machine. In order to not lockup the 
> machine - somewhere in the 2.4 cycle - the ksoftirqd thread was 
> introduced.
> 
> If you have CONFIG_PREEMPT_RT_FULL and you call softirqs in the interrupt 
> thread, you could only stall the interrupt thread. If you do the same 
> thing without CONFIG_PREEMPT_RT_FULL, you stall the whole CPU.
> 

Note, PREEMPT_RT also uses ksoftirqd too. Although we may set it to RT
prio 1. It is triggered if the softirq itself raises a softirq of the
same kind, and then the work is passed off to the ksoftirqd.

Causing the interrupt thread to stall (or by going into a loop of
softirqs) is likely to lock up the CPU on RT too, as interrupt threads
are usually run at priority 50, which will keep normal threads from
running on that CPU.

-- Steve