linux-kernel - Re: [PATCH v10 04/10] drivers: qcom: rpmh: add RPMH helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Jun 2018 11:53:28 +0530
From:   Raju P L S S S N <rplsssn@...eaurora.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-arm-msm@...r.kernel.org,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Evan Green <evgreen@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Lina Iyer <ilina@...eaurora.org>
Subject: Re: [PATCH v10 04/10] drivers: qcom: rpmh: add RPMH helper functions

Hi,

On 6/14/2018 2:39 AM, Doug Anderson wrote:
> Hi,
> 
> On Mon, Jun 11, 2018 at 10:25 AM, Raju P L S S S N
> <rplsssn@...eaurora.org> wrote:
>> +void rpmh_tx_done(const struct tcs_request *msg, int r)
>> +{
>> +       struct rpmh_request *rpm_msg = container_of(msg, struct rpmh_request,
>> +                                                   msg);
>> +       struct completion *compl = rpm_msg->completion;
>> +
>> +       rpm_msg->err = r;
>> +
>> +       if (r)
>> +               dev_err(rpm_msg->dev, "RPMH TX fail in msg addr=%#x, err=%d\n",
>> +                       rpm_msg->msg.cmds[0].addr, r);
>> +
>> +       /* Signal the blocking thread we are done */
>> +       if (compl)
>> +               complete(compl);
>> +}
>> +EXPORT_SYMBOL(rpmh_tx_done);
> 
> You're back to too many EXPORT_SYMBOL's again.  Just use this rule of thumb:
> 
> * If it's static, no EXPORT_SYMBOL.
> 
> * If the prototype is in "rpmh-internal.h", no EXPORT_SYMBOL.
> 
> * If the prototype is in "rpmh.h", then yes EXPORT_SYMBOL.
> 
> In the case of rpmh_tx_done: the protype is in rpmh-internal.h
> 
> 
> To fix, squash in crosreview.com/1099841
> 
> 
> -Doug
> 

Sure. Thanks for review.