linux-kernel - Re: [PATCH] doc: add description to dirtytime_expire

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a1efc1b-c586-616f-1668-b4b8f24f873a@suse.com>
Date:   Fri, 15 Jun 2018 10:04:57 +0300
From:   Nikolay Borisov <nborisov@...e.com>
To:     Yang Shi <yang.shi@...ux.alibaba.com>, tytso@....edu,
        corbet@....net, akpm@...ux-foundation.org
Cc:     linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] doc: add description to dirtytime_expire_seconds



On 31.05.2018 02:56, Yang Shi wrote:
> commit 1efff914afac8a965ad63817ecf8861a927c2ace ("fs: add
> dirtytime_expire_seconds sysctl") introduced dirtytime_expire_seconds
> knob, but there is not description about it in
> Documentation/sysctl/vm.txt.
> 
> Add the description for it.
> 
> Cc: Theodore Ts'o <tytso@....edu>
> Signed-off-by: Yang Shi <yang.shi@...ux.alibaba.com>
> ---
> I didn't dig into the old review discussion about why the description
> was not added at the first place. I'm supposed every knob under /proc/sys
> should have a brief description.
> 
>  Documentation/sysctl/vm.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl/vm.txt
> index 17256f2..f4f4f9c 100644
> --- a/Documentation/sysctl/vm.txt
> +++ b/Documentation/sysctl/vm.txt
> @@ -27,6 +27,7 @@ Currently, these files are in /proc/sys/vm:
>  - dirty_bytes
>  - dirty_expire_centisecs
>  - dirty_ratio
> +- dirtytime_expire_seconds
>  - dirty_writeback_centisecs
>  - drop_caches
>  - extfrag_threshold
> @@ -178,6 +179,16 @@ The total available memory is not equal to total system memory.
>  
>  ==============================================================
>  
> +dirtytime_expire_seconds
> +
> +When a lazytime inode is constantly having its pages dirtied, it with an

The second part of this sentence, after the comma doesn't parse.

> +updated timestamp will never get chance to be written out.  This tunable
> +is used to define when dirty inode is old enough to be eligible for
> +writeback by the kernel flusher threads. And, it is also used as the
> +interval to wakeup dirtytime_writeback thread. It is expressed in seconds.

I think the final sentence is a bit redundant, given the very explicit
name of the knob.

> +
> +==============================================================
> +
>  dirty_writeback_centisecs
>  
>  The kernel flusher threads will periodically wake up and write `old' data
>