linux-kernel - Re: [PATCH v3] dmaengine: rcar-dmac: don't use DMAC error interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Jun 2018 07:15:35 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     <vkoul@...nel.org>, Dan Williams <dan.j.williams@...el.com>,
        Magnus Damm <magnus.damm@...il.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Kieran Bingham <kieran@...uared.org.uk>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        <dmaengine@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3] dmaengine: rcar-dmac: don't use DMAC error interrupt


Hi Geert

> > rcar-dmac has 2 types of interrupt, 1) error IRQ (for all),
> > 2) IRQ for each channels.
> > If error happens on some channels, the error IRQ will be handled
> > by 1), and "all" channels will be restarted.
> > But in this design, error handling itself will be problem for
> > non error channel users.
> > This patch removes 1) handler, and handles error IRQ on 2)
> 
> Thank you, that explains the rationale!

Thanks

> BTW, how can you trigger an error, for testing?

We created local patch to break address alignment.

Best regards
---
Kuninori Morimoto