linux-kernel - Re: [PATCH] media: venus: keep resolution when adjusting format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8ccddbe-7ff8-8098-2406-db8447c998f9@linaro.org>
Date:   Fri, 15 Jun 2018 11:11:48 +0300
From:   Stanimir Varbanov <stanimir.varbanov@...aro.org>
To:     Alexandre Courbot <acourbot@...omium.org>,
        Stanimir Varbanov <stanimir.varbanov@...aro.org>
Cc:     linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: venus: keep resolution when adjusting format

Hi Alex,

Thanks for the patch!

On 06/05/2018 07:50 AM, Alexandre Courbot wrote:
> When checking a format for validity, the resolution is reset to 1280x720
> whenever the pixel format is not supported. This behavior can mislead
> user-space into believing that this is the only resolution supported,
> and looks strange considering that if we try/set the same format with
> just the pixel format changed to a valid one, the call will this time
> succeed without altering the resolution.
> 
> Resolution is managed independently of the pixel format, so remove this
> reset.
> 
> Signed-off-by: Alexandre Courbot <acourbot@...omium.org>
> ---
>  drivers/media/platform/qcom/venus/vdec.c | 2 --
>  drivers/media/platform/qcom/venus/venc.c | 2 --
>  2 files changed, 4 deletions(-)

Acked-by: Stanimir Varbanov <stanimir.varbanov@...aro.org>

-- 
regards,
Stan