linux-kernel - Re: [linux-sunxi] Re: [PATCH v2 04/27] dt-bindings: display: sunxi-drm: Add TCON TOP description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Jun 2018 10:45:42 +0200
From:   Maxime Ripard <maxime.ripard@...tlin.com>
To:     Jernej Škrabec <jernej.skrabec@...l.net>
Cc:     linux-sunxi@...glegroups.com, wens@...e.org, robh+dt@...nel.org,
        airlied@...ux.ie, gustavo@...ovan.org,
        maarten.lankhorst@...ux.intel.com, seanpaul@...omium.org,
        mark.rutland@....com, dri-devel@...ts.freedesktop.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [linux-sunxi] Re: [PATCH v2 04/27] dt-bindings: display:
 sunxi-drm: Add TCON TOP description

On Wed, Jun 13, 2018 at 06:03:21PM +0200, Jernej Škrabec wrote:
> > > +Required properties:
> > > +  - compatible: value must be one of:
> > > +    * allwinner,sun8i-r40-tcon-top
> > > +  - reg: base address and size of the memory-mapped region.
> > > +  - clocks: phandle to the clocks feeding the TCON TOP
> > > +    * bus: TCON TOP interface clock
> > > +  - clock-names: clock name mentioned above
> > > +  - resets: phandle to the reset line driving the DRC
> > 
> > s/DRC/TCON TOP/ ?
> 
> Yes, copy & paste issue
> 
> > 
> > > +    * rst: TCON TOP reset line
> > 
> > Remaining consistent with the clock name would be great
> 
> You mean "ahb"? I noticed that most other nodes with reset lines don't have a 
> name associated. Maybe I could just drop it and use first specified reset?

It's called bus in the binding, but yes. And yeah, we can drop the
name as well.

> > 
> > > +  - reset-names: reset name mentioned above
> > > +  - #clock-cells : must contain 1
> > 
> > An example would be nice here
> 
> You mean node example? with ports? In the past, Rob was against examples 
> unless really necessary. Node from R40 DTSI can serve as an example.

Ok.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)