linux-kernel - Re: [PATCH] crypto: chtls - use after free in chtls_pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180615151303.gvj3es3jfepfmycs@gondor.apana.org.au>
Date:   Fri, 15 Jun 2018 23:13:03 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Harsh Jain <harsh@...lsio.com>,
        Atul Gupta <atul.gupta@...lsio.com>,
        "David S. Miller" <davem@...emloft.net>,
        Michael Werner <werner@...lsio.com>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] crypto: chtls - use after free in chtls_pt_recvmsg()

On Fri, Jun 01, 2018 at 10:59:25AM +0300, Dan Carpenter wrote:
> We call chtls_free_skb() but then we dereference it on the next lines.
> Also "skb" can't be NULL, we just dereferenced it on the line before.
> 
> I have moved the free down a couple lines to fix this issue.
> 
> Fixes: 17a7d24aa89d ("crypto: chtls - generic handling of data and hdr")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt