linux-kernel - Re: [PATCH] selftests: sparc64: Fix to do nothing on non-sparc64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa06cf9a-e38b-df0d-3e15-a8ecff1e923f@kernel.org>
Date:   Fri, 15 Jun 2018 10:51:58 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     David Miller <davem@...hat.com>
Cc:     tom.hromatka@...cle.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, f.fainelli@...il.com,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] selftests: sparc64: Fix to do nothing on non-sparc64

On 06/15/2018 10:41 AM, David Miller wrote:
> From: Shuah Khan <shuah@...nel.org>
> Date: Fri, 15 Jun 2018 10:33:21 -0600
> 
>> On 06/13/2018 11:20 AM, Tom Hromatka wrote:
>>> Thanks, Shuah!
>>>
>>> Tom
>>>
>>>
>>> On 06/12/2018 05:23 PM, Shuah Khan (Samsung OSG) wrote:
>>>> sparc64 test fails with the following errors on non-sparc64 systems. Fix
>>>> the Makefile to do nothing on non-sparc64 systems to suppress the errors:
>>>>
>>>> make run_tests
>>>> adi-test.c: Assembler messages:
>>>> adi-test.c:302: Error: no such instruction: `rd %tick,%r13'
>>>> adi-test.c:304: Error: no such instruction: `rd %tick,%rbp'
>>>> adi-test.c:190: Error: no such instruction: `rd %tick,%rbp'
>>>> adi-test.c:192: Error: no such instruction: `rd %tick,%rdx'
>>>> adi-test.c:273: Error: no such instruction: `rd %tick,%rbx'
>>>> adi-test.c:276: Error: no such instruction: `rd %tick,%rdx'
>>>> adi-test.c:217: Error: no such instruction: `rd %tick,%rbp'
>>>> adi-test.c:220: Error: no such instruction: `rd %tick,%rdx'
>>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax'
>>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax'
>>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax'
>>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax'
>>>> adi-test.c:246: Error: no such instruction: `rd %tick,%rbp'
>>>> adi-test.c:248: Error: no such instruction: `rd %tick,%rdx'
>>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax'
>>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax'
>>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax'
>>>> <builtin>: recipe for target 'adi-test' failed
>>>> make[1]: *** [adi-test] Error 1
>>>> adi: [FAIL]
>>>> ./drivers_test.sh: 24: ./drivers_test.sh: ./adi-test: not found
>>>> ../lib.mk:73: recipe for target 'run_tests' failed
>>>> make: *** [run_tests] Error 1
>>>>
>>>> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@...nel.org>
>>>
>>> Reviewed-by: Tom Hromatka <tom.hromatka@...cle.com>
>>>
>>
>> get_maintainers didn't include your name for this patch. Would you like to
>> take this fix through sparc tree? It would be good to get this in for
>> 4.18-rc2
>>
>> If so, please let me know if you would like me to resend the patch
>> with Tom's Reviewed-by tag.
> 
> I'm very busy, so this time could you merge this for me?  Thanks!
> 
> Acked-by: David S. Miller <davem@...emloft.net>
> 

Okay. I will take care of this.

thanks,
-- Shuah