linux-kernel - Re: [PATCH] RFC: bus: fix semicolon.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7ace76dba30099151e645aa7496c84dff18b29a.camel@perches.com>
Date:   Fri, 15 Jun 2018 11:06:59 -0700
From:   Joe Perches <joe@...ches.com>
To:     Julia Lawall <julia.lawall@...6.fr>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RFC: bus: fix semicolon.cocci warnings

On Fri, 2018-06-15 at 19:59 +0200, Julia Lawall wrote:
> From: kbuild test robot <fengguang.wu@...el.com>
> 
>  Remove unneeded semicolon.
[]
> +++ b/drivers/bus/96boards-mezzanines/96boards-secure96.c
> @@ -223,7 +223,7 @@ out_unreg_leds:
>  	platform_device_unregister(sec->leds_device);
>  	for (i = 0; i < ARRAY_SIZE(ledinfos); i++) {
>  		mezzanine_ls_put_gpiod(ls, sec->secure96_leds[i].gpiod);
> -	};
> +	}
>  	return ERR_PTR(ret);
>  }
>  EXPORT_SYMBOL_GPL(secure96_populate);
> @@ -244,6 +244,6 @@ void secure96_depopulate(void *data)
>  	platform_device_unregister(sec->leds_device);
>  	for (i = 0; i < ARRAY_SIZE(ledinfos); i++) {
>  		mezzanine_ls_put_gpiod(sec->ls, sec->secure96_leds[i].gpiod);
> -	};
> +	}
>  }
>  EXPORT_SYMBOL_GPL(secure96_depopulate);

While these are clearly correct, perhaps it would
be better to remove the braces too.