linux-kernel - Re: [PATCH v3] scsi: xen-scsifront: add error handling for xenbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201806151049.P2KlZOXq%fengguang.wu@intel.com>
Date:   Fri, 15 Jun 2018 10:32:50 +0800
From:   kbuild test robot <lkp@...el.com>
To:     linux-scsi-owner@...r.kernel.org
Cc:     kbuild-all@...org, Zhouyang Jia <jiazhouyang09@...il.com>,
        Juergen Gross <jgross@...e.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        xen-devel@...ts.xenproject.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] scsi: xen-scsifront: add error handling for
 xenbus_printf

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on xen-tip/linux-next]
[also build test WARNING on v4.17 next-20180614]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/linux-scsi-owner-vger-kernel-org/scsi-xen-scsifront-add-error-handling-for-xenbus_printf/20180615-070404
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: i386-randconfig-sb0-06140922 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers//scsi/xen-scsifront.c: In function 'scsifront_sdev_configure':
>> drivers//scsi/xen-scsifront.c:663:21: warning: passing argument 1 of 'xenbus_dev_error' from incompatible pointer type
       xenbus_dev_error(&info->dev->dev, err,
                        ^
   In file included from drivers//scsi/xen-scsifront.c:50:0:
   include/xen/xenbus.h:224:6: note: expected 'struct xenbus_device *' but argument is of type 'struct device *'
    void xenbus_dev_error(struct xenbus_device *dev, int err, const char *fmt, ...);
         ^
   drivers//scsi/xen-scsifront.c: In function 'scsifront_sdev_destroy':
   drivers//scsi/xen-scsifront.c:681:21: warning: passing argument 1 of 'xenbus_dev_error' from incompatible pointer type
       xenbus_dev_error(&info->dev->dev, err,
                        ^
   In file included from drivers//scsi/xen-scsifront.c:50:0:
   include/xen/xenbus.h:224:6: note: expected 'struct xenbus_device *' but argument is of type 'struct device *'
    void xenbus_dev_error(struct xenbus_device *dev, int err, const char *fmt, ...);
         ^
   drivers//scsi/xen-scsifront.c: In function 'scsifront_do_lun_hotplug':
   drivers//scsi/xen-scsifront.c:1022:23: warning: passing argument 1 of 'xenbus_dev_error' from incompatible pointer type
         xenbus_dev_error(&dev->dev, err,
                          ^
   In file included from drivers//scsi/xen-scsifront.c:50:0:
   include/xen/xenbus.h:224:6: note: expected 'struct xenbus_device *' but argument is of type 'struct device *'
    void xenbus_dev_error(struct xenbus_device *dev, int err, const char *fmt, ...);
         ^
   drivers//scsi/xen-scsifront.c:1042:23: warning: passing argument 1 of 'xenbus_dev_error' from incompatible pointer type
         xenbus_dev_error(&dev->dev, err,
                          ^
   In file included from drivers//scsi/xen-scsifront.c:50:0:
   include/xen/xenbus.h:224:6: note: expected 'struct xenbus_device *' but argument is of type 'struct device *'
    void xenbus_dev_error(struct xenbus_device *dev, int err, const char *fmt, ...);
         ^

vim +/xenbus_dev_error +663 drivers//scsi/xen-scsifront.c

   653	
   654	static int scsifront_sdev_configure(struct scsi_device *sdev)
   655	{
   656		struct vscsifrnt_info *info = shost_priv(sdev->host);
   657		int err;
   658	
   659		if (info && current == info->curr) {
   660			err = xenbus_printf(XBT_NIL, info->dev->nodename,
   661				      info->dev_state_path, "%d", XenbusStateConnected);
   662			if (err) {
 > 663				xenbus_dev_error(&info->dev->dev, err,
   664					"%s: writing dev_state_path", __func__);
   665				return err;
   666			}
   667		}
   668	
   669		return 0;
   670	}
   671	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32162 bytes)