linux-kernel - Re: [PATCH] drm/nouveau/nvif: remove const attribute from nvif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOd=ntzV5x+rDSH6VEoS2ONZacnqeemewNgv3Aotm3Hd-hA@mail.gmail.com>
Date:   Fri, 15 Jun 2018 15:58:23 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     bskeggs@...hat.com, airlied@...ux.ie
Cc:     Matthias Kaehlcke <mka@...omium.org>, Jessica Yu <jeyu@...nel.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg KH <gregkh@...uxfoundation.org>,
        dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/nouveau/nvif: remove const attribute from nvif_mclass

On Fri, Jun 15, 2018 at 3:56 PM Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
>
> Similar to commit 0bf8bf50eddc ("module: Remove
> const attribute from alias for MODULE_DEVICE_TABLE")
>
> Fixes many -Wduplicate-decl-specifier warnings due to the combination of
> const typeof() of already const variables.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
> ---
>  drivers/gpu/drm/nouveau/include/nvif/object.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/include/nvif/object.h b/drivers/gpu/drm/nouveau/include/nvif/object.h
> index a2d5244ff2b7..7f188f66931e 100644
> --- a/drivers/gpu/drm/nouveau/include/nvif/object.h
> +++ b/drivers/gpu/drm/nouveau/include/nvif/object.h
> @@ -78,7 +78,7 @@ struct nvif_mclass {
>  #define nvif_mclass(o,m) ({                                                    \
>         struct nvif_object *object = (o);                                      \
>         struct nvif_sclass *sclass;                                            \
> -       const typeof(m[0]) *mclass = (m);                                      \
> +       typeof(m[0]) *mclass = (m);                                      \

Sorry, this messes up the spaces at the end, will send a v2.

>         int ret = -ENODEV;                                                     \
>         int cnt, i, j;                                                         \
>                                                                                 \
> --
> 2.18.0.rc1.244.gcf134e6275-goog
>

-- 
Thanks,
~Nick Desaulniers