linux-kernel - Re: [PATCH 1/3] usb: dwc2: host: do not delay retries for CONTROL IN transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=UHyc+VAc+d8ODXLQWXfB0grH140+ZFJU3hoJScYLMJ9g@mail.gmail.com>
Date:   Fri, 15 Jun 2018 16:49:41 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Minas Harutyunyan <hminas@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] usb: dwc2: host: do not delay retries for CONTROL IN transfers

Hi,

On Fri, Jun 15, 2018 at 3:01 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> When handling split transactions we will try to delay retry after
> getting a NAK from the device. This works well for BULK transfers that
> can be polled for essentially forever. Unfortunately, on slower systems
> at boot time, when the kernel is busy enumerating all the devices (USB
> or not), we issue a bunch of control requests (reading device
> descriptors, etc). If we get a NAK for the IN part of the control
> request and delay retry for too long (because the system is busy), we
> may confuse the device when we finally get to reissue SSPLIT/CSPLIT IN
> and the device will respond with STALL. As a result we end up with
> failure to get device descriptor and will fail to enumerate the device:
>
> [    3.428801] usb 2-1.2.1: new full-speed USB device number 9 using dwc2
> [    3.508576] usb 2-1.2.1: device descriptor read/8, error -32
> [    3.699150] usb 2-1.2.1: device descriptor read/8, error -32
> [    3.891653] usb 2-1.2.1: new full-speed USB device number 10 using dwc2
> [    3.968859] usb 2-1.2.1: device descriptor read/8, error -32
> ...
>
> Let's not delay retries of split CONTROL IN transfers, as this allows us
> to reliably enumerate devices at boot time.
>
> Fixes 38d2b5fb75c1 ("usb: dwc2: host: Don't retry NAKed transactions right away")

nit: I think there's supposed to be a ":" after "Fixes"

> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>  drivers/usb/dwc2/hcd_intr.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

This seems like a sane fix to me.

Reviewed-by: Douglas Anderson <dianders@...omium.org>