linux-kernel - [PATCH] firmware: Update Kconfig help text for Google firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180616220531.GB14131@decadent.org.uk>
Date:   Sat, 16 Jun 2018 23:05:31 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Julius Werner <jwerner@...omium.org>,
        Thierry Escande <thierry.escande@...labora.com>
Cc:     linux-kernel@...r.kernel.org,
        Paul Menzel <pm.debian@...glemail.com>
Subject: [PATCH] firmware: Update Kconfig help text for Google firmware

The help text for GOOGLE_FIRMWARE states that it should only be
enabled when building a kernel for Google's own servers.  However, it
is now also a dependency for various Chromebook firmware drivers.

Update the help text to reflect this double duty.  Add the qualifier
"server" to the help text for GOOGLE_SMI, which doesn't appear to be
useful on Chromebooks.

Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
 drivers/firmware/google/Kconfig | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
index f16b381a569c..6fda2c5c69e4 100644
--- a/drivers/firmware/google/Kconfig
+++ b/drivers/firmware/google/Kconfig
@@ -2,9 +2,8 @@ menuconfig GOOGLE_FIRMWARE
 	bool "Google Firmware Drivers"
 	default n
 	help
-	  These firmware drivers are used by Google's servers.  They are
-	  only useful if you are working directly on one of their
-	  proprietary servers.  If in doubt, say "N".
+	  These firmware drivers are used by Google servers and
+	  Chromebooks.  If in doubt, say "N".
 
 if GOOGLE_FIRMWARE
 
@@ -14,8 +13,8 @@ config GOOGLE_SMI
 	select EFI_VARS
 	help
 	  Say Y here if you want to enable SMI callbacks for Google
-	  platforms.  This provides an interface for writing to and
-	  clearing the EFI event log and reading and writing NVRAM
+	  server platforms.  This provides an interface for writing to
+	  and clearing the EFI event log and reading and writing NVRAM
 	  variables.
 
 config GOOGLE_COREBOOT_TABLE

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)