linux-kernel - Re: [RFC][PATCHES] getting rid of int *open in ->atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 17 Jun 2018 19:22:02 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [RFC][PATCHES] getting rid of int *open in ->atomic_open() and
 friends

On Sat, Jun 09, 2018 at 06:10:51AM +0100, Al Viro wrote:
> On Fri, Jun 08, 2018 at 11:57:06AM -0700, Linus Torvalds wrote:
> > I'm obviously biased since I asked for this, but:
> > 
> > On Fri, Jun 8, 2018 at 11:48 AM Al Viro <viro@...iv.linux.org.uk> wrote:
> > >
> > >  33 files changed, 135 insertions(+), 180 deletions(-)
> > 
> > this already looks nice.
> > 
> > I'll go through the individual patches and see if there's anything
> > there that raises my hackles. Silence will mean assent in this case
> 
> BTW, looking through alloc_file() callers - in cxl_getfile() we have
[snip]

> That's a double iput when we hit alloc_file failure...  There's a bunch
> of callers that can be massaged into something along such lines (not
> sharing that bug, though) and I wonder if we would be better off with
> wrapper like

... and call-by-editor strikes again - this window we've got it
cut'n'pasted into ocxlflash_getfile(), with the same double iput
in place...