linux-kernel - Re: [tip:x86/pti] x86/asm: Pad assembly functions with INT3 instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180617194747.GA21160@zn.tnic>
Date:   Sun, 17 Jun 2018 21:47:47 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Mike Galbraith <efault@....de>
Cc:     Alexey Dobriyan <adobriyan@...il.com>,
        torvalds@...ux-foundation.org, tglx@...utronix.de,
        mingo@...nel.org, jpoimboe@...hat.com, luto@...nel.org,
        peterz@...radead.org, brgerst@...il.com, hpa@...or.com,
        linux-kernel@...r.kernel.org, dvlasenk@...hat.com,
        h.peter.anvin@...el.com,
        linux-tip-commits <linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/pti] x86/asm: Pad assembly functions with INT3
 instructions

On Sun, Jun 17, 2018 at 04:02:58PM +0200, Mike Galbraith wrote:
> (/me does that.. all better)
> 
> From 6ac281ee69f4cb5b581d5f49662fb56b6326155a Mon Sep 17 00:00:00 2001
> From: Borislav Petkov <bp@...e.de>
> Date: Sun, 17 Jun 2018 13:57:42 +0200
> Subject: [PATCH] x86/crypto: Add a missing RET
> 
> crypto_aegis128_aesni_enc_tail() needs to return too.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>

[ Mike: took care of the other tail calls. ]
Signed-off-by: Mike Galbraith <efault@....de>

> ---
>  arch/x86/crypto/aegis128-aesni-asm.S  |    1 +
>  arch/x86/crypto/aegis128l-aesni-asm.S |    1 +
>  arch/x86/crypto/aegis256-aesni-asm.S  |    1 +
>  arch/x86/crypto/morus1280-avx2-asm.S  |    1 +
>  arch/x86/crypto/morus1280-sse2-asm.S  |    1 +
>  arch/x86/crypto/morus640-sse2-asm.S   |    1 +
>  6 files changed, 6 insertions(+)

...

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.