linux-kernel - Re: [PATCH v2 1/4] vt: preserve unicode values corresponding to screen characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YSQ.7.76.1806171909250.16670@knanqh.ubzr>
Date:   Sun, 17 Jun 2018 19:17:51 -0400 (EDT)
From:   Nicolas Pitre <nicolas.pitre@...aro.org>
To:     valdis.kletnieks@...edu
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dave Mielke <Dave@...lke.cc>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] vt: preserve unicode values corresponding to
 screen characters

On Sun, 17 Jun 2018, valdis.kletnieks@...edu wrote:

> On Sun, 17 Jun 2018 15:07:03 -0400, Nicolas Pitre said:
> 
> > diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> > index 1eb1a376a0..7b636638b3 100644
> > --- a/drivers/tty/vt/vt.c
> > +++ b/drivers/tty/vt/vt.c
> > @@ -317,6 +317,171 @@ void schedule_console_callback(void)
> >  	schedule_work(&console_work);
> >  }
> >
> > +/*
> > + * Code to manage unicode-based screen buffers
> > + */
> > +
> > +#ifdef NO_VC_UNI_SCREEN
> 
> This preprocessor variable seems to be dangling in the breeze, with
> no way for it to get set?  As a result, we pick up the #else define by
> default.

That's actually what's intended here.

If vc_screen.c ever becomes configurable then this could be used to 
compile out this code. Or if someone wants to disable it for some 
debugging reasons. For now it is just a self-explanatory placeholder 
with very little chance of being set by mistake for any other purpose.


Nicolas