linux-kernel - Re: [PATCH] leds: ledtrig-activity: use ktime_get_boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180618150715.GA30470@amd>
Date:   Mon, 18 Jun 2018 17:07:15 +0200
From:   Pavel Machek <pavel@....cz>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        y2038@...ts.linaro.org, Kees Cook <keescook@...omium.org>,
        Willy Tarreau <w@....eu>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: ledtrig-activity: use ktime_get_boot_ns()

Hi!

> get_monotonic_boottime() is deprecated, so let's convert this to
> the simpler ktime_get_boot_ns().
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Have you tested it?

> diff --git a/drivers/leds/trigger/ledtrig-activity.c b/drivers/leds/trigger/ledtrig-activity.c
> index 5081894082bd..589c1bc4d0b9 100644
> --- a/drivers/leds/trigger/ledtrig-activity.c
> +++ b/drivers/leds/trigger/ledtrig-activity.c
> @@ -37,7 +37,6 @@ static void led_activity_function(struct timer_list *t)
>  	struct activity_data *activity_data = from_timer(activity_data, t,
>  							 timer);
>  	struct led_classdev *led_cdev = activity_data->led_cdev;
> -	struct timespec boot_time;
>  	unsigned int target;
>  	unsigned int usage;
>  	int delay;
> @@ -57,7 +56,7 @@ static void led_activity_function(struct timer_list *t)
>  		return;
>  	}
>  
> -	get_monotonic_boottime(&boot_time);
> +	curr_boot = ktime_get_boot_ns();
>  
>  	cpus = 0;
>  	curr_used = 0;
> @@ -76,7 +75,6 @@ static void led_activity_function(struct timer_list *t)
>  	 * down to 16us, ensuring we won't overflow 32-bit computations below
>  	 * even up to 3k CPUs, while keeping divides cheap on smaller systems.
>  	 */
> -	curr_boot = timespec_to_ns(&boot_time) * cpus;

Original code is pretty weird (notice the * cpus), so I'm
double-checking.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)