linux-kernel - Re: [PATCH] ALSA: ctxfi: use enum type CT_SUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Jun 2018 17:40:48 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Stefan Agner" <stefan@...er.ch>
Cc:     "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: ctxfi: use enum type CT_SUM_CTL where appropriate

On Sun, 17 Jun 2018 15:46:49 +0200,
Stefan Agner wrote:
> 
> Currently a variable of type enum CT_AMIXER_CTL is used for enum
> CT_SUM_CTL values. This leads to warnings when using clang:
> sound/pci/ctxfi/ctmixer.c:945:32: warning: implicit conversion from enumeration type
>       'enum CT_SUM_CTL' to different enumeration type 'enum CT_AMIXER_CTL'
>       [-Wenum-conversion]
>         for (i = AMIXER_MASTER_F, j = SUM_IN_F;
>                                     ~ ^~~~~~~~
> sound/pci/ctxfi/ctmixer.c:975:29: warning: implicit conversion from enumeration type
>       'enum CT_SUM_CTL' to different enumeration type 'enum CT_AMIXER_CTL'
>       [-Wenum-conversion]
>         for (i = AMIXER_PCM_F, j = SUM_IN_F; i <= AMIXER_PCM_S; i++, j++) {
>                                  ~ ^~~~~~~~
> 
> Introduce enum CT_SUM_CTL k and it instead.
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>

Applied, thanks.


Takashi