linux-kernel - Re: [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property

Open Source and information security mailing list archives

Message-Id: <20180618183038.c8ee3164ff62ab5e27535c5c@bidouilliste.com>
Date:   Mon, 18 Jun 2018 18:30:38 +0200
From:   Emmanuel Vadot <manu@...ouilliste.com>
To:     Lucas Stach <l.stach@...gutronix.de>
Cc:     Emmanuel Vadot <manu@...ebsd.org>, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de,
        fabio.estevam@....com, linux-imx@....com, robh+dt@...nel.org,
        mark.rutland@....com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path
 property

On Mon, 18 Jun 2018 18:03:17 +0200
Lucas Stach <l.stach@...gutronix.de> wrote:

> Am Montag, den 18.06.2018, 17:42 +0200 schrieb Emmanuel Vadot:
> > The RIoTboard debug uart is connected to serial1.
> > Add a chosen property in the DTS so OS knows what serial port to use for
> > the console.
> > 
> > > Signed-off-by: Emmanuel Vadot <manu@...ebsd.org>
> > ---
> >  arch/arm/boot/dts/imx6dl-riotboard.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
> > index 2e98c92adff7..315d2ae6fa45 100644
> > --- a/arch/arm/boot/dts/imx6dl-riotboard.dts
> > +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
> > @@ -19,6 +19,10 @@
> > >  		reg = <0x10000000 0x40000000>;
> > >  	};
> >  
> > > +	chosen {
> > +		stdout-path = "serial1:115200n8";
> 
> If there a reason to deviate from the "stdout-path = &uart1;" notation
> used by other i.MX boards?
> 
> Regards,
> Lucas

 This is, AFAIK, the proper way to specify the stdout-path.
 See
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/chosen.txt#L31

 Cheers,

> > +	};
> > +
> > >  	regulators {
> > >  		compatible = "simple-bus";
> > >  		#address-cells = <1>;
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Emmanuel Vadot <manu@...ouilliste.com> <manu@...ebsd.org>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives