linux-kernel - Re: [PATCH] libahci: Fix possible Spectre-v1 pmp indexing in ahci_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180618180456.GB1351649@devbig577.frc2.facebook.com>
Date:   Mon, 18 Jun 2018 11:04:56 -0700
From:   Tejun Heo <tj@...nel.org>
To:     John Garry <john.garry@...wei.com>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        dan.carpenter@...cle.com
Subject: Re: [PATCH] libahci: Fix possible Spectre-v1 pmp indexing in
 ahci_led_store()

On Fri, Jun 08, 2018 at 06:26:33PM +0800, John Garry wrote:
> Currently smatch warns of possible Spectre-V1 issue in ahci_led_store():
> drivers/ata/libahci.c:1150 ahci_led_store() warn: potential spectre issue 'pp->em_priv' (local cap)
> 
> Userspace controls @pmp from following callchain:
> em_message->store()
> ->ata_scsi_em_message_store()
> -->ap->ops->em_store()
> --->ahci_led_store()
> 
> After the mask+shift @pmp is effectively an 8b value, which is used to
> index into an array of length 8, so sanitize the array index.
> 
> Signed-off-by: John Garry <john.garry@...wei.com>

Applied to libata/for-4.18-fixes.

Thanks.

-- 
tejun