linux-kernel - Re: [PATCH 4.14 102/189] scsi: vmw-pvscsi: return DID_BUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EA21F664-6574-4321-B2FC-3CC602EB7363@vmware.com>
Date:   Mon, 18 Jun 2018 18:32:45 +0000
From:   Jim Gill <jgill@...are.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Sasha Levin <alexander.levin@...rosoft.com>
Subject: Re: [PATCH 4.14 102/189] scsi: vmw-pvscsi: return DID_BUS_BUSY for
 adapter-initated aborts

Fine by me.




On 6/18/18, 1:13 AM, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org> wrote:

>4.14-stable review patch.  If anyone has any objections, please let me know.
>
>------------------
>
>From: Jim Gill <jgill@...are.com>
>
>[ Upstream commit f4b024271ae3e9786e5d6f1c05b01b57a74e1d6d ]
>
>The vmw_pvscsi driver returns DID_ABORT for commands aborted internally
>by the adapter, leading to the filesystem going read-only. Change the
>result to DID_BUS_BUSY, causing the kernel to retry the command.
>
>Signed-off-by: Jim Gill <jgill@...are.com>
>Signed-off-by: Martin K. Petersen <martin.petersen@...cle.com>
>Signed-off-by: Sasha Levin <alexander.levin@...rosoft.com>
>Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>---
> drivers/scsi/vmw_pvscsi.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>--- a/drivers/scsi/vmw_pvscsi.c
>+++ b/drivers/scsi/vmw_pvscsi.c
>@@ -609,7 +609,7 @@ static void pvscsi_complete_request(stru
> 			break;
> 
> 		case BTSTAT_ABORTQUEUE:
>-			cmd->result = (DID_ABORT << 16);
>+			cmd->result = (DID_BUS_BUSY << 16);
> 			break;
> 
> 		case BTSTAT_SCSIPARITY:
>
>