linux-kernel - Re: [PATCHv3 00/18] atomics: API cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180618192126.l7qyuthsc6eqkigb@salmiak>
Date:   Mon, 18 Jun 2018 20:21:27 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Will Deacon <will.deacon@....com>
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        boqun.feng@...il.com, mingo@...nel.org, albert@...ive.com,
        arnd@...db.de, benh@...nel.crashing.org, geert@...ux-m68k.org,
        ink@...assic.park.msu.ru, linux@...linux.org.uk,
        mattst88@...il.com, mpe@...erman.id.au, palmer@...ive.com,
        paulus@...ba.org, rth@...ddle.net, vgupta@...opsys.com
Subject: Re: [PATCHv3 00/18] atomics: API cleanups

On Mon, Jun 18, 2018 at 05:38:06PM +0100, Will Deacon wrote:
> On Mon, Jun 18, 2018 at 11:19:01AM +0100, Mark Rutland wrote:
> > This series contains a few cleanups of the atomic API, fixing
> > inconsistencies between atomic_* and atomic64_*, and minimizing
> > repetition in arch code. This is nicer for arch code, and the improved
> > regularity will help when generating the atomic headers in future.
> 
> Apart from the Alpha patch:
> 
> Reviewed-by: Will Deacon <will.deacon@....com>

Cheers! I assume that also holds with patch 7 fixes up to use s64.

> I also tried to compare disassembly before/after, but the changes to
> add_unless made that quite fiddly for anything using it as a backend.
> 
> Do you plan to move arm64 over to atomic-instrumented.h at some point?

That's the plan -- there's still a way to go with the generated atomic headers
for that to work.

Thanks,
Mark.