linux-kernel - Re: [PATCH v4 3/3] bitfield: add tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1529354821.3092.42.camel@sipsolutions.net>
Date:   Mon, 18 Jun 2018 22:47:01 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v4 3/3] bitfield: add tests

On Mon, 2018-06-18 at 23:44 +0300, Andy Shevchenko wrote:
> On Mon, Jun 18, 2018 at 11:37 PM, Johannes Berg
> <johannes@...solutions.net> wrote:
> > Add tests for the bitfield helpers. The constant ones will all
> > be folded to nothing by the compiler (if everything is correct
> > in the header file), and the variable ones do some tests against
> > open-coding the necessary shifts.
> > 
> > A few test cases that should fail/warn compilation are provided
> > under ifdef.
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> Though license mismatch. Either GPL-2.0+ for SPDX, or "GPL v2" for _LICENSE().

Sigh. Yeah, I guess I'll resend. That's what I get for copy/pasting.

johannes