linux-kernel - Re: [PATCH v2] firmware: Update Kconfig help text for Google firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Jun 2018 16:13:39 -0700
From:   Julius Werner <jwerner@...omium.org>
To:     ben@...adent.org.uk
Cc:     Julius Werner <jwerner@...omium.org>,
        Thierry Escande <thierry.escande@...labora.com>,
        LKML <linux-kernel@...r.kernel.org>, pm.debian@...glemail.com
Subject: Re: [PATCH v2] firmware: Update Kconfig help text for Google firmware

LGTM

Reviewed-by: Julius Werner <jwerner@...omium.org>
On Mon, Jun 18, 2018 at 3:55 PM Ben Hutchings <ben@...adent.org.uk> wrote:
>
> The help text for GOOGLE_FIRMWARE states that it should only be
> enabled when building a kernel for Google's own servers.  However,
> many of the drivers dependent on it are also useful on Chromebooks or
> on any platform using coreboot.
>
> Update the help text to reflect this double duty.
>
> Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
> v2: Mention coreboot, and don't touch GSMI help text
>
>  drivers/firmware/google/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> index f16b381a569c..ca049ecf5cfd 100644
> --- a/drivers/firmware/google/Kconfig
> +++ b/drivers/firmware/google/Kconfig
> @@ -2,9 +2,9 @@ menuconfig GOOGLE_FIRMWARE
>         bool "Google Firmware Drivers"
>         default n
>         help
> -         These firmware drivers are used by Google's servers.  They are
> -         only useful if you are working directly on one of their
> -         proprietary servers.  If in doubt, say "N".
> +         These firmware drivers are used by Google servers,
> +         Chromebooks and other devices using coreboot firmware.
> +         If in doubt, say "N".
>
>  if GOOGLE_FIRMWARE
>