linux-kernel - Re: [PATCH] staging: speakup: refactor synths array to use a list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2123576446.627448.1529312132509@email.1and1.co.uk>
Date:   Mon, 18 Jun 2018 09:55:32 +0100 (BST)
From:   Justin Skists <justin.skists@...za.co.uk>
To:     Samuel Thibault <samuel.thibault@...-lyon.org>
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        "Speakup is a screen review system for Linux." 
        <speakup@...ux-speakup.org>, Gregory Nowak <greg@...gn.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: speakup: refactor synths array to use a list


> On 18 June 2018 at 09:46 Samuel Thibault <samuel.thibault@...-lyon.org> wrote:
> 
> 
> Justin Skists, le lun. 18 juin 2018 09:41:44 +0100, a ecrit:
> > > On 18 June 2018 at 06:34 Gregory Nowak <greg@...gn.net> wrote:
> > > With /sys/accessibility/speakup/synth set to bns, I am getting output
> > > alternately from the bns and from soft. It's as if speakup can't make
> > > up its mind which synthesizer is being used. When I echo soft
> > > >/sys/accessibility/speakup/synth, I get no speech at all from either
> > > synthesizer.
> > 
> > Is this a known issue, or a regression due to the patch?
> 
> I don't think it was a known issue, but I don't think it can be a
> regression due to the patch, since none of that is handled by the
> array/list at stake.

OK, thanks. That's what I thought, too.

When I was going through the driver code, to become familiar with it, there
were a few places that I thought needed a closer look. But I need to finish
setting up a regression testing system before I do.

Justin.