linux-kernel - Re: [PATCH 1/7] MIPS: dts: Add aliases node for lantiq danube serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539411c1-82b7-cf76-71cf-d50f3303f50f@linux.intel.com>
Date:   Mon, 18 Jun 2018 17:42:14 +0800
From:   "Wu, Songjun" <songjun.wu@...ux.intel.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     hua.ma@...ux.intel.com, yixin.zhu@...ux.intel.com,
        chuanhua.lei@...el.com,
        "open list:RALINK MIPS ARCHITECTURE" <linux-mips@...ux-mips.org>,
        qi-ming.wu@...el.com, linux-clk <linux-clk@...r.kernel.org>,
        linux-serial@...r.kernel.org, DTML <devicetree@...r.kernel.org>,
        James Hogan <jhogan@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Rob Herring <robh+dt@...nel.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Rutland <mark.rutland@....com>,
        Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH 1/7] MIPS: dts: Add aliases node for lantiq danube serial



On 6/14/2018 6:03 PM, Arnd Bergmann wrote:
> On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu <songjun.wu@...ux.intel.com> wrote:
>> Previous implementation uses a hard-coded register value to check if
>> the current serial entity is the console entity.
>> Now the lantiq serial driver uses the aliases for the index of the
>> serial port.
>> The lantiq danube serial dts are updated with aliases to support this.
>>
>> Signed-off-by: Songjun Wu <songjun.wu@...ux.intel.com>
>> ---
>>
>>   arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi b/arch/mips/boot/dts/lantiq/danube.dtsi
>> index 2dd950181f8a..7a9e15da6bd0 100644
>> --- a/arch/mips/boot/dts/lantiq/danube.dtsi
>> +++ b/arch/mips/boot/dts/lantiq/danube.dtsi
>> @@ -4,6 +4,10 @@
>>          #size-cells = <1>;
>>          compatible = "lantiq,xway", "lantiq,danube";
>>
>> +       aliases {
>> +               serial0 = &asc1;
>> +       };
>> +
> You generally want the aliases to be part of the board specific file,
> not every board numbers their serial ports in the same way.
>
>         Arnd
In this chip only asc1 can be used as console,  so serial0 is defined in 
chip specific file.