linux-kernel - Re: [RFC][PATCH] printk: do not call console drivers from printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180618095932.pshslpzntgfr7lg4@pathway.suse.cz>
Date:   Mon, 18 Jun 2018 11:59:32 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [RFC][PATCH] printk: do not call console drivers from
 printk_safe context

On Mon 2018-06-18 15:39:16, Sergey Senozhatsky wrote:
> On (04/25/18 16:48), Petr Mladek wrote:
> > 
> > So I agree that printk_safe context does not help much. And I fine
> > with this patch.
> > 
> 
> Petr, do you want me to resend the patch with the updated commit message?

I am sorry for abandoning this patch. Hmm, I am a bit unsure about it now.

The printk_safe context partly prevents recursion problems when
console drivers print messages. I expected that this patch
would have been pushed together with a better solution for
the recursion. But we still do not have any.

Would you mind to keep it on hold for now? I know that it might
help in some situations. But it also makes the code more complicated
and there is some risk of a regression. I would prefer when it
is pushed in a situation when it is a clear win.

Best Regards,
Petr