linux-kernel - Re: [PATCH 0/3] sound/usb/line6: fix some styling issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Jun 2018 12:39:53 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Roman Sommer" <roman.sommer@....de>
Cc:     <alsa-devel@...a-project.org>, "Kees Cook" <keescook@...omium.org>,
        "Daniel Graefe" <daniel.graefe@....de>,
        "Bhumika Goyal" <bhumirks@...il.com>,
        "Fabián Inostroza" 
        <soulsonceonfire@...il.com>, <linux-kernel@...cs.fau.de>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Kate Stewart" <kstewart@...uxfoundation.org>,
        "Philippe Ombredanne" <pombredanne@...b.com>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Takashi Sakamoto" <o-takashi@...amocchi.jp>,
        "Hans P. Möller Ebner" 
        <hmoller@...cl>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] sound/usb/line6: fix some styling issues

On Mon, 18 Jun 2018 12:29:36 +0200,
Roman Sommer wrote:
> 
> CC: Jaroslav Kysela <perex@...ex.cz>
> CC: Takashi Iwai <tiwai@...e.com>
> CC: Takashi Sakamoto <o-takashi@...amocchi.jp>
> CC: "Hans P. Möller Ebner" <hmoller@...cl>
> CC: Kees Cook <keescook@...omium.org>
> CC: Kate Stewart <kstewart@...uxfoundation.org>
> CC: Thomas Gleixner <tglx@...utronix.de>
> CC: "Fabián Inostroza" <soulsonceonfire@...il.com>
> CC: Bhumika Goyal <bhumirks@...il.com>
> CC: Philippe Ombredanne <pombredanne@...b.com>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: alsa-devel@...a-project.org
> CC: linux-kernel@...r.kernel.org
> 
> 
> This patchseries addresses some styling issues in sound/usb/line6 found by
> checkpatch.

Are you working further on this driver to fix any real bugs (or
implements something new), or it's an action "just because checkpatch
tells"?  I'd take such cleanup patches only for the former case.


thanks,

Takashi


> 
> Roman Sommer (3):
>   sound/line6: checkpatch: fix block comment style
>   sound/line6: unsigned -> unsigned int
>   sound/line6: add newline after declarations
> 
>  sound/usb/line6/capture.c  |  20 ++++-----
>  sound/usb/line6/driver.c   | 110 ++++++++++++++++++++++-----------------------
>  sound/usb/line6/driver.h   |  33 +++++++-------
>  sound/usb/line6/midi.c     |  24 +++++-----
>  sound/usb/line6/midibuf.c  |   6 +--
>  sound/usb/line6/pcm.c      |  26 +++++------
>  sound/usb/line6/pcm.h      |  74 +++++++++++++++---------------
>  sound/usb/line6/playback.c |  36 ++++++++-------
>  sound/usb/line6/pod.c      |  60 ++++++++++++-------------
>  sound/usb/line6/podhd.c    |   8 ++--
>  sound/usb/line6/toneport.c |  30 ++++++-------
>  sound/usb/line6/variax.c   |  40 ++++++++---------
>  12 files changed, 235 insertions(+), 232 deletions(-)
> 
> -- 
> 2.7.4
> 
>