linux-kernel - Re: [PATCH v8 5/5] ipc: Add a new ipcmni_compat sysctl to fall back to old behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Jun 2018 19:36:16 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Waiman Long <longman@...hat.com>
Cc:     kbuild-all@...org, "Luis R. Rodriguez" <mcgrof@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-doc@...r.kernel.org,
        Al Viro <viro@...iv.linux.org.uk>,
        Matthew Wilcox <willy@...radead.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Takashi Iwai <tiwai@...e.de>, Davidlohr Bueso <dbueso@...e.de>,
        Waiman Long <longman@...hat.com>
Subject: Re: [PATCH v8 5/5] ipc: Add a new ipcmni_compat sysctl to fall back
 to old behavior

Hi Waiman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc1 next-20180618]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Waiman-Long/ipc-IPCMNI-limit-check-for-mni-increase-that-limit/20180618-183206
config: i386-randconfig-x013-201824 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from ipc/mqueue.c:43:0:
   ipc/util.h: In function 'sem_check_semmni':
>> ipc/util.h:251:54: error: 'ipcmni_max' undeclared (first use in this function); did you mean 'icmp_mib'?
     return ((ns->sem_ctls[3] < 0) || (ns->sem_ctls[3] > ipcmni_max))
                                                         ^~~~~~~~~~
                                                         icmp_mib
   ipc/util.h:251:54: note: each undeclared identifier is reported only once for each function it appears in
--
   In file included from ipc/msgutil.c:22:0:
   ipc/util.h: In function 'sem_check_semmni':
>> ipc/util.h:251:54: error: 'ipcmni_max' undeclared (first use in this function); did you mean 'pci_iomap'?
     return ((ns->sem_ctls[3] < 0) || (ns->sem_ctls[3] > ipcmni_max))
                                                         ^~~~~~~~~~
                                                         pci_iomap
   ipc/util.h:251:54: note: each undeclared identifier is reported only once for each function it appears in

vim +251 ipc/util.h

   239	
   240	struct kern_ipc_perm *ipc_obtain_object_check(struct ipc_ids *ids, int id);
   241	int ipcget(struct ipc_namespace *ns, struct ipc_ids *ids,
   242				const struct ipc_ops *ops, struct ipc_params *params);
   243	void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
   244			void (*free)(struct ipc_namespace *, struct kern_ipc_perm *));
   245	
   246	static inline int sem_check_semmni(struct ipc_namespace *ns) {
   247		/*
   248		 * Check semmni range [0, ipcmni_max]
   249		 * semmni is the last element of sem_ctls[4] array
   250		 */
 > 251		return ((ns->sem_ctls[3] < 0) || (ns->sem_ctls[3] > ipcmni_max))
   252			? -ERANGE : 0;
   253	}
   254	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28855 bytes)