linux-kernel - Re: [PATCH v2] drm: Replace NULL with error value in drm_prime_pages_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0b8ffa2-cf75-5a8c-7341-29855780fc00@epam.com>
Date:   Mon, 18 Jun 2018 15:32:48 +0300
From:   Oleksandr Andrushchenko <Oleksandr_Andrushchenko@...m.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Oleksandr Andrushchenko <andr2000@...il.com>
Cc:     xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, airlied@...ux.ie,
        daniel.vetter@...el.com, seanpaul@...omium.org,
        gustavo@...ovan.org, jgross@...e.com, boris.ostrovsky@...cle.com
Subject: Re: [PATCH v2] drm: Replace NULL with error value in
 drm_prime_pages_to_sg

On 06/18/2018 03:29 PM, Dan Carpenter wrote:
> On Mon, Jun 18, 2018 at 09:07:09AM +0300, Oleksandr Andrushchenko wrote:
>>   drivers/gpu/drm/drm_gem_cma_helper.c    | 2 +-
>>   drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
>> index 80a5115c3846..ce868ce288fb 100644
>> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
>> @@ -436,7 +436,7 @@ struct sg_table *drm_gem_cma_prime_get_sg_table(struct drm_gem_object *obj)
>>   
>>   	sgt = kzalloc(sizeof(*sgt), GFP_KERNEL);
>>   	if (!sgt)
>> -		return NULL;
>> +		return ERR_PTR(-ENOMEM);
>>   
>>   	ret = dma_get_sgtable(obj->dev->dev, sgt, cma_obj->vaddr,
>>   			      cma_obj->paddr, obj->size);
>
> If dma_get_sgtable() fails then we return NULL.
>
> Fix that and it should be good.
You mean I can put your r-b with that fixed?
> regards,
> dan carpenter
>