linux-kernel - Re: [PATCH] drm/arm/malidp:- Rectify the width and height passed to rotmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180618130934.GG15072@e110455-lin.cambridge.arm.com>
Date:   Mon, 18 Jun 2018 14:09:35 +0100
From:   Liviu Dudau <liviu.dudau@....com>
To:     Ayan Kumar Halder <ayan.halder@....com>
Cc:     brian.starkey@....com, malidp@...s.arm.com, airlied@...ux.ie,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        nd@....com
Subject: Re: [PATCH] drm/arm/malidp:- Rectify the width and height passed to
 rotmem_required()

On Fri, Jun 15, 2018 at 01:54:36PM +0100, Ayan Kumar Halder wrote:
> The width and height needs to be swapped
> 
> Signed-off-by: Ayan Kumar halder <ayan.halder@....com>
> Reviewed-by: Brian Starkey <brian.starkey@....com>
> Reviewed-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@....com>
> ---
>  drivers/gpu/drm/arm/malidp_planes.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index 377382e..533cdde 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -244,8 +244,8 @@ static int malidp_de_plane_check(struct drm_plane *plane,
>  	if (state->rotation != DRM_MODE_ROTATE_0 || fb->modifier) {
>  		int val;
>  
> -		val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_h,
> -						     state->crtc_w,
> +		val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_w,
> +						     state->crtc_h,
>  						     fb->format->format,
>  						     !!(fb->modifier));

Ooops, thanks for catching this! 

Acked-by: Liviu Dudau <liviu.dudau@....com>


>  		if (val < 0)
> -- 
> 2.7.4
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯