linux-kernel - Re: [PATCH 2/3] bcache: do not assign in if condition in bcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef26a060-689d-8ee9-57fb-b8473ca97fea@suse.de>
Date:   Mon, 18 Jun 2018 21:44:35 +0800
From:   Coly Li <colyli@...e.de>
To:     Florian Schmaus <flo@...kplace.eu>,
        Kent Overstreet <kent.overstreet@...il.com>,
        linux-bcache@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] bcache: do not assign in if condition in
 bcache_init()

On 2018/6/18 6:09 PM, Florian Schmaus wrote:
> Fixes an error condition reported by checkpatch.pl which is caused by
> assigning a variable in an if condition.
> 
> Signed-off-by: Florian Schmaus <flo@...kplace.eu>

Signed-off-by: Coly Li <colyli@...e.de>

Added into for-next patch set.

Thanks.

Coly Li

> ---
>  drivers/md/bcache/super.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index db7177d422e5..f09f4f046315 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -2328,9 +2328,15 @@ static int __init bcache_init(void)
>  		return bcache_major;
>  	}
>  
> -	if (!(bcache_wq = alloc_workqueue("bcache", WQ_MEM_RECLAIM, 0)) ||
> -	    !(bcache_kobj = kobject_create_and_add("bcache", fs_kobj)) ||
> -	    bch_request_init() ||
> +	bcache_wq = alloc_workqueue("bcache", WQ_MEM_RECLAIM, 0);
> +	if (!bcache_wq)
> +		goto err;
> +
> +	bcache_kobj = kobject_create_and_add("bcache", fs_kobj);
> +	if (!bcache_kobj)
> +		goto err;
> +
> +	if (bch_request_init() ||
>  	    bch_debug_init(bcache_kobj) || closure_debug_init() ||
>  	    sysfs_create_files(bcache_kobj, files))
>  		goto err;
>