linux-kernel - [PATCH 2/3] Staging:rtl8192e Fix Comparison to true is error prone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1529337929-8947-1-git-send-email-jananis37@gmail.com>
Date:   Mon, 18 Jun 2018 12:05:29 -0400
From:   Janani Sankara Babu <jananis37@...il.com>
To:     gregkh@...uxfoundation.org
Cc:     johannes.berg@...el.com, davem@...emloft.net,
        keescook@...omium.org, Rene.Hickersberger@....at,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Janani Sankara Babu <jananis37@...il.com>
Subject: [PATCH 2/3] Staging:rtl8192e Fix Comparison to true is error prone

This patch removes the comaprison to bool value in the code

Signed-off-by: Janani Sankara Babu <jananis37@...il.com>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index ccd898a..c6de34a 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -365,7 +365,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
 	pAdmittedBA = &pTS->TxAdmittedBARecord;


-	if (pAdmittedBA->bValid == true) {
+	if (pAdmittedBA->bValid) {
 		netdev_dbg(ieee->dev, "%s(): ADDBA response already admitted\n",
 			   __func__);
 		return -1;
@@ -485,7 +485,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct tx_ts_record *pTS,
 {
 	struct ba_record *pBA = &pTS->TxPendingBARecord;

-	if (pBA->bValid == true && bOverwritePending == false)
+	if (pBA->bValid && !bOverwritePending)
 		return;

 	DeActivateBAEntry(ieee, pBA);
--
1.9.1