linux-kernel - Re: [PATCH] staging: rtsx: remove rtsx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Jun 2018 17:57:55 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        y2038@...ts.linaro.org, devel@...verdev.osuosl.org,
        Micky Ching <micky_ching@...lsil.com.cn>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtsx: remove rtsx_trace() and related code

> @@ -117,7 +112,6 @@ static int ms_transfer_data(struct rtsx_chip *chip, u8 trans_mode,
>  	enum dma_data_direction dir;
>  
>  	if (!buf || !buf_len) {
> -		rtsx_trace(chip);
>  		return STATUS_FAIL;
>  	}
>  

You're introducing a bunch of checkpatch.pl warnings.  Normally we would
ask you to not do that...  I don't care too much because someone will
eventually fix it, but still...

regards,
dan carpenter