linux-kernel - Re: [PATCH] jfs: use time64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Jun 2018 14:06:47 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     y2038@...ts.linaro.org, jfs-discussion@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jfs: use time64_t for otime

On 06/19/2018 10:51 AM, Arnd Bergmann wrote:
> The file creation time in the inode uses time_t which is defined differently
> on 32-bit and 64-bit architectures and deprecated. The representation in
> the inode uses an unsigned 32-bit number, but this gets wrapped around
> after year 2038 when assigned to a time_t.
> 
> This changes the type to time64_t, so we can support the full range of
> timestamps between 1970 and 2106 on 32-bit systems like we do on 64-bit
> systems already, and matching what we do for the atime/ctime/mtime stamps
> since the introduction of 64-bit timestamps in VFS.
> 
> Note: the otime stamp is not actually used anywhere at the moment in
> the kernel, it is just set when writing a file, so none of this really
> makes a difference unless we implement setting the btime field in the
> getattr() callback.

This looks good to me. I'll push it to linux-next and target the next
merge window.

Thanks,
Shaggy

> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  fs/jfs/jfs_incore.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jfs/jfs_incore.h b/fs/jfs/jfs_incore.h
> index 1f26d1910409..d5c46f86b2ef 100644
> --- a/fs/jfs/jfs_incore.h
> +++ b/fs/jfs/jfs_incore.h
> @@ -43,7 +43,7 @@ struct jfs_inode_info {
>  	pxd_t	ixpxd;		/* inode extent descriptor	*/
>  	dxd_t	acl;		/* dxd describing acl	*/
>  	dxd_t	ea;		/* dxd describing ea	*/
> -	time_t	otime;		/* time created	*/
> +	time64_t otime;		/* time created	*/
>  	uint	next_index;	/* next available directory entry index */
>  	int	acltype;	/* Type of ACL	*/
>  	short	btorder;	/* access order	*/
>