linux-kernel - Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180619214459.GI31750@zn.tnic>
Date:   Tue, 19 Jun 2018 23:44:59 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Brijesh Singh <brijesh.singh@....com>
Cc:     Richard Weinberger <richard.weinberger@...il.com>,
        Janakarajan Natarajan <Janakarajan.Natarajan@....com>,
        Tom Lendacky <thomas.lendacky@....com>, x86@...nel.org,
        kvm <kvm@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krcmar <rkrcmar@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, felix@...dspaten.org
Subject: Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

On Tue, Jun 19, 2018 at 11:32:56PM +0200, Borislav Petkov wrote:
> config CRYPTO_DEV_SP_PSP
>         bool "Platform Security Processor (PSP) device"
>         default y
>         depends on CRYPTO_DEV_CCP_DD && X86_64
> 
> so CRYPTO_DEV_SP_PSP already depends on CRYPTO_DEV_CCP_DD!
> 
> So why should KVM_AMD_SEV depend on CRYPTO_DEV_CCP_DD too?!? Do you
> catch my drift?

And then in addition to that, KVM_AMD_SEV needs to "synchronize"
selection states so that KVM_AMD *and* CRYPTO_DEV_SP_PSP both have the
same setting - either =m or =y - so that the build works.

I can't think of a proper way to fix that right now, though, need to
sleep on it.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--