linux-kernel - Re: [PATCH] scsi: cxlflash: Change return type for fault handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180619232930.GB10658@p8tul1-build.aus.stglabs.ibm.com>
Date:   Tue, 19 Jun 2018 18:29:30 -0500
From:   "Matthew R. Ochs" <mrochs@...ux.vnet.ibm.com>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     Uma Krishnan <ukrishn@...ux.vnet.ibm.com>,
        Matthew Wilcox <willy@...radead.org>,
        "Manoj N. Kumar" <manoj@...ux.vnet.ibm.com>,
        James Bottomley <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        linux-kernel@...r.kernel.org,
        Sabyasachi Gupta <sabyasachi.linux@...il.com>,
        brajeswar.linux@...il.com
Subject: Re: [PATCH] scsi: cxlflash: Change return type for fault handler

On Tue, Jun 19, 2018 at 11:11:35PM +0530, Souptick Joarder wrote:
> On Tue, Jun 19, 2018 at 7:41 PM, Uma Krishnan
> <ukrishn@...ux.vnet.ibm.com> wrote:
> >
> >
> >> On Jun 19, 2018, at 12:10 AM, Souptick Joarder <jrdr.linux@...il.com> wrote:
> >>
> >> On Thu, Jun 14, 2018 at 4:53 AM, Matthew R. Ochs
> >> <mrochs@...ux.vnet.ibm.com> wrote:
> >>> On Tue, Jun 12, 2018 at 01:12:04AM +0530, Souptick Joarder wrote:
> >>>> Use new return type vm_fault_t for fault handler. For
> >>>> now, this is just documenting that the function returns
> >>>> a VM_FAULT value rather than an errno. Once all instances
> >>>> are converted, vm_fault_t will become a distinct type.
> >>>>
> >>>> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
> >>>>
> >>>> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> >>>
> >>> This looks fine to me.
> >>>
> >>> FYI that there is another handler for this driver in a series
> >>> destined for 4.18 and currently in next/master.
> >>>
> >>> Acked-by: Matthew R. Ochs <mrochs@...ux.vnet.ibm.com>
> >>>
> >>
> >> Matthew, is this patch queued for 4.19 ?
> >>
> > Below is the commit that added fault handler in ocxl. It is in 4.18 rc1 (upstream/master tree)
> >
> > commit 93b8f8df552c5a30bfddb75a632f1b2a436c2cae
> >     scsi: cxlflash: Support adapter context mmap and release
> 
> 
> No, that's a different patch with commit
> 93b8f8df552c5a30bfddb75a632f1b2a436c2cae.
> Not the patch under discussion in this mail thread :)
> 
> Anyway the other patch with commit 93b8f8df552c5a30b also has to be modified
> to use new return type vm_fault_t for fault handler ocxlflash_mmap_fault().
> 
> Shall I modify and submit the same ?
> 

Since this has not yet been queued for 4.19, please submit a v2 with the
modifications to also update the return type for ocxlflash_mmap_fault().


-matt