linux-kernel - Re: [PATCH] staging: rtl8723bs: remove get_monotonic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a03_CdgLCfov7Ynn69-V3L7RKoJ=6jxsoTWf7+NM_8-Aw@mail.gmail.com>
Date:   Tue, 19 Jun 2018 10:09:03 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Quytelda Kahja <quytelda@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Bastien Nocera <hadess@...ess.net>,
        Hans de Goede <hdegoede@...hat.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Quytelda Kahja <quytelda@...alin.org>,
        Arushi Singhal <arushisinghal19971997@...il.com>,
        driverdevel <devel@...verdev.osuosl.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: remove get_monotonic_boottime()

On Tue, Jun 19, 2018 at 9:18 AM, Quytelda Kahja <quytelda@...il.com> wrote:
> I'm fairly sure this doesn't matter functionally (yet), but perhaps
> 'notify_timestamp' should be updated to an 's64' type since ktime_to_us()
> returns a signed type?

I think it's fine either way, ktime_t is only signed to deal with
differences between
times and the theoretical case of running with local time set to a
date before 1970
(which I'm sure fails for a number of other reasons), but boottime is guaranteed
to be positive as well as monotonically increasing, so an unsigned
type is fine here.

> That note aside, I think this is good.

> Reviewed-by: Quytelda Kahja <quytelda@...alin.org>

Thanks for taking a look!

     Arnd