linux-kernel - Re: [PATCH v2 2/4] ARM: dts: i.MX6: imx6dl-mamoj: Add parallel display support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180619024157.GX16091@dragon>
Date:   Tue, 19 Jun 2018 10:41:58 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Jagan Teki <jagan@...rulasolutions.com>
Cc:     linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Fabio maggi <fabio.mauri@...cino.it>, lamiaposta71@...il.com,
        Andrea CORTESE <andrea.cortese@...cino.it>,
        "davide . bonfanti" <davide.bonfanti@...cino.it>,
        Shyam Saini <shyam.saini@...rulasolutions.com>,
        Michael Trimarchi <michael@...rulasolutions.com>,
        Simone CIANNI <simone.cianni@...cino.it>,
        Raffaele RECALCATI <raffaele.recalcati@...cino.it>
Subject: Re: [PATCH v2 2/4] ARM: dts: i.MX6: imx6dl-mamoj: Add parallel
 display support

On Thu, Jun 07, 2018 at 07:17:46PM +0530, Jagan Teki wrote:
> This patch adds parallel display support for i.MX6DL Mamoj board
> along with relevant backlight through pwm.
> 
> LCD power sequence is added by 'Michael Trimarchi'.
> 
> Signed-off-by: Simone CIANNI <simone.cianni@...cino.it>
> Signed-off-by: Raffaele RECALCATI <raffaele.recalcati@...cino.it>
> Signed-off-by: Michael Trimarchi <michael@...rulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@...rulasolutions.com>
> Reviewed-by: Fabio Estevam <fabio.estevam@....com>
> ---
> Changes for v2:
> - collect Fabio r-w-b tag
> 
>  arch/arm/boot/dts/imx6dl-mamoj.dts | 185 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 185 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-mamoj.dts b/arch/arm/boot/dts/imx6dl-mamoj.dts
> index 6b2d29138bed..ed9050c5dbcc 100644
> --- a/arch/arm/boot/dts/imx6dl-mamoj.dts
> +++ b/arch/arm/boot/dts/imx6dl-mamoj.dts
> @@ -6,11 +6,133 @@
>  
>  /dts-v1/;
>  
> +#include <dt-bindings/gpio/gpio.h>
>  #include "imx6dl.dtsi"
>  
>  / {
>  	model = "BTicino i.MX6DL Mamoj board";
>  	compatible = "bticino,imx6dl-mamoj", "fsl,imx6dl";
> +
> +	backlight_lcd: backlight-lcd {
> +		compatible = "pwm-backlight";
> +		pwms = <&pwm3 0 25000>; /* 25000ns -> 40kHz */
> +		brightness-levels = <0 4 8 16 32 64 128 160 192 224 255>;
> +		default-brightness-level = <7>;
> +	};
> +
> +	lcd_display: disp0 {

'display' for node name.

> +		compatible = "fsl,imx-parallel-display";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		interface-pix-fmt = "rgb24";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_ipu1_lcdif>;
> +		status = "okay";
> +
> +		port@0 {
> +			reg = <0>;
> +
> +			lcd_display_in: endpoint {
> +				remote-endpoint = <&ipu1_di0_disp0>;
> +			};
> +		};
> +
> +		port@1 {
> +			reg = <1>;
> +
> +			lcd_display_out: endpoint {
> +				remote-endpoint = <&lcd_panel_in>;
> +			};
> +		};
> +	};
> +
> +	panel-lcd {
> +		compatible = "rocktech,rk070er9427";
> +		backlight = <&backlight_lcd>;
> +		power-supply = <&reg_lcd_lr>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_lcd_power>;
> +
> +		port {
> +			lcd_panel_in: endpoint {
> +				remote-endpoint = <&lcd_display_out>;
> +			};
> +		};
> +	};
> +
> +	reg_lcd_3v3: regulator-lcd-dvdd {
> +		compatible = "regulator-fixed";
> +		regulator-name = "lcd-dvdd";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio3 1 0>;
> +		enable-active-high;
> +		startup-delay-us = <21000>;
> +	};
> +
> +	reg_lcd_power: regulator-lcd-power {
> +		compatible = "regulator-fixed";
> +		regulator-name = "lcd-enable";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio3 6 0>;
> +		enable-active-high;
> +		vin-supply = <&reg_lcd_3v3>;
> +	};
> +
> +	reg_lcd_vgl: regulator-lcd-vgl {
> +		compatible = "regulator-fixed";
> +		regulator-name = "lcd-vgl";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio2 20 GPIO_ACTIVE_HIGH>;
> +		startup-delay-us = <6000>;
> +		enable-active-high;
> +		vin-supply = <&reg_lcd_power>;
> +	};
> +
> +	reg_lcd_vgh: regulator-lcd-vgh {
> +		compatible = "regulator-fixed";
> +		regulator-name = "lcd-vgh";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio3 31 GPIO_ACTIVE_HIGH>;
> +		startup-delay-us = <6000>;
> +		enable-active-high;
> +		vin-supply = <&reg_lcd_avdd>;
> +	};
> +
> +	reg_lcd_vcom: regulator-lcd-vcom {
> +		compatible = "regulator-fixed";
> +		regulator-name = "lcd-vcom";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio4 14 GPIO_ACTIVE_HIGH>;
> +		startup-delay-us = <11000>;
> +		enable-active-high;
> +		vin-supply = <&reg_lcd_vgh>;
> +	};
> +
> +	reg_lcd_lr: regulator-lcd-lr {
> +		compatible = "regulator-fixed";
> +		regulator-name = "lcd-lr";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +		vin-supply = <&reg_lcd_vcom>;
> +	};
> +
> +	reg_lcd_avdd: regulator-lcd-avdd {
> +		compatible = "regulator-fixed";
> +		regulator-name = "lcd-avdd";
> +		regulator-min-microvolt = <10280000>;
> +		regulator-max-microvolt = <10280000>;
> +		gpio = <&gpio2 13 GPIO_ACTIVE_HIGH>;
> +		startup-delay-us = <6000>;
> +		enable-active-high;
> +		vin-supply = <&reg_lcd_vgl>;
> +	};
>  };
>  
>  &fec {
> @@ -147,6 +269,16 @@
>  	};
>  };
>  
> +&ipu1_di0_disp0 {
> +	remote-endpoint = <&lcd_display_in>;
> +};
> +
> +&pwm3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_pwm3>;
> +	status = "okay";
> +};
> +
>  &uart3 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_uart3>;
> @@ -200,6 +332,59 @@
>  		>;
>  	};
>  
> +	pinctrl_ipu1_lcdif: pinctrlipu1lcdif { /* parallel port 24-bit */
> +		fsl,pins = <
> +			MX6QDL_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK 0x10 /* VDOUT_PCLK */
> +			MX6QDL_PAD_DI0_PIN15__IPU1_DI0_PIN15       0x10
> +			MX6QDL_PAD_DI0_PIN2__IPU1_DI0_PIN02        0x10 /* VDOUT_HSYNC */
> +			MX6QDL_PAD_DI0_PIN3__IPU1_DI0_PIN03        0x10 /* VDOUT_VSYNC */
> +			MX6QDL_PAD_DI0_PIN4__IPU1_DI0_PIN04	   0x80000000 /* VDOUT_RESET */

Use a proper configuration value rather than relying on what
firmware/reset gives.

> +			MX6QDL_PAD_DISP0_DAT0__IPU1_DISP0_DATA00   0x10
> +			MX6QDL_PAD_DISP0_DAT1__IPU1_DISP0_DATA01   0x10
> +			MX6QDL_PAD_DISP0_DAT2__IPU1_DISP0_DATA02   0x10
> +			MX6QDL_PAD_DISP0_DAT3__IPU1_DISP0_DATA03   0x10
> +			MX6QDL_PAD_DISP0_DAT4__IPU1_DISP0_DATA04   0x10
> +			MX6QDL_PAD_DISP0_DAT5__IPU1_DISP0_DATA05   0x10
> +			MX6QDL_PAD_DISP0_DAT6__IPU1_DISP0_DATA06   0x10
> +			MX6QDL_PAD_DISP0_DAT7__IPU1_DISP0_DATA07   0x10
> +			MX6QDL_PAD_DISP0_DAT8__IPU1_DISP0_DATA08   0x10
> +			MX6QDL_PAD_DISP0_DAT9__IPU1_DISP0_DATA09   0x10
> +			MX6QDL_PAD_DISP0_DAT10__IPU1_DISP0_DATA10  0x10
> +			MX6QDL_PAD_DISP0_DAT11__IPU1_DISP0_DATA11  0x10
> +			MX6QDL_PAD_DISP0_DAT12__IPU1_DISP0_DATA12  0x10
> +			MX6QDL_PAD_DISP0_DAT13__IPU1_DISP0_DATA13  0x10
> +			MX6QDL_PAD_DISP0_DAT14__IPU1_DISP0_DATA14  0x10
> +			MX6QDL_PAD_DISP0_DAT15__IPU1_DISP0_DATA15  0x10
> +			MX6QDL_PAD_DISP0_DAT16__IPU1_DISP0_DATA16  0x10
> +			MX6QDL_PAD_DISP0_DAT17__IPU1_DISP0_DATA17  0x10
> +			MX6QDL_PAD_DISP0_DAT18__IPU1_DISP0_DATA18  0x10
> +			MX6QDL_PAD_DISP0_DAT19__IPU1_DISP0_DATA19  0x10
> +			MX6QDL_PAD_DISP0_DAT20__IPU1_DISP0_DATA20  0x10
> +			MX6QDL_PAD_DISP0_DAT21__IPU1_DISP0_DATA21  0x10
> +			MX6QDL_PAD_DISP0_DAT22__IPU1_DISP0_DATA22  0x10
> +			MX6QDL_PAD_DISP0_DAT23__IPU1_DISP0_DATA23  0x10
> +		>;
> +	};
> +
> +	pinctrl_lcd_power: lcd_power {

The node name and above pinctrlipu1lcdif is not consistent to other
pinctrl nodes.

Shawn

> +		fsl,pins = <
> +			MX6QDL_PAD_EIM_DA1__GPIO3_IO01		0x40013058 /* EN_LCD33V */
> +			MX6QDL_PAD_SD4_DAT5__GPIO2_IO13		0x4001b0b0 /* EN_AVDD */
> +			MX6QDL_PAD_EIM_D31__GPIO3_IO31		0x40013058 /* ENVGH */
> +			MX6QDL_PAD_EIM_A18__GPIO2_IO20		0x40013058 /* ENVGL */
> +			MX6QDL_PAD_EIM_DA6__GPIO3_IO06		0x40013058 /* LCD_POWER */
> +			MX6QDL_PAD_KEY_COL4__GPIO4_IO14		0x40013058 /* EN_VCOM_LCD */
> +			MX6QDL_PAD_KEY_ROW4__GPIO4_IO15		0x40013058 /* LCD_L_R */
> +			MX6QDL_PAD_EIM_DA2__GPIO3_IO02		0x40013058 /* LCD_U_D */
> +		>;
> +	};
> +
> +	pinctrl_pwm3: pwm3grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_SD4_DAT1__PWM3_OUT 0x1b0b1
> +		>;
> +	};
> +
>  	pinctrl_uart3: uart3grp {
>  		fsl,pins = <
>  			MX6QDL_PAD_EIM_D24__UART3_TX_DATA	0x1b0b1
> -- 
> 2.14.3
>