linux-kernel - Re: [PATCH net-next 3/3] tcp: use monotonic timestamps for PAWS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a2Z+H7r=dWqYmKbJ2mAMZEdvT6GdKjSMbweabqBwOZYEg@mail.gmail.com>
Date:   Tue, 19 Jun 2018 11:23:45 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Harsh Jain <harsh@...lsio.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Atul Gupta <atul.gupta@...lsio.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Michael Werner <werner@...lsio.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Florian Westphal <fw@...len.de>,
        Christoph Paasch <cpaasch@...le.com>,
        Lawrence Brakmo <brakmo@...com>,
        Ursula Braun <ubraun@...ux.vnet.ibm.com>,
        Priyaranjan Jha <priyarjha@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Ivan Delalande <colona@...sta.com>,
        Maciej Żenczykowski <maze@...gle.com>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 3/3] tcp: use monotonic timestamps for PAWS

On Mon, Jun 18, 2018 at 5:59 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On 06/18/2018 08:22 AM, Arnd Bergmann wrote:
>
> Please use the time_after32(), since ktime_get_seconds() is time64_t while ts_recent_stamp is int.
>
> Same remark for tcp_twsk_unique()
>
> Lets clean up this stuff, thanks !

Sure, no problem. Note that as ktime_get_seconds() uses CLOCK_MONOTONIC, it is
guaranteed to return a number that fits into a positive 32-bit number
(for about 136
years after boot to be precise). Most users of time_after() or
time_after32() are for
jiffies values that do overflow regularly, but it doesn't hurt to use
time_after32()
here for illustration.

        Arnd