linux-kernel - RE: [tip:x86/pti] x86/asm: Pad assembly functions with INT3 instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01de2a572d964a349e556e6c638e06d4@AcuMS.aculab.com>
Date:   Tue, 19 Jun 2018 11:27:54 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Mike Galbraith' <efault@....de>, Borislav Petkov <bp@...en8.de>
CC:     Alexey Dobriyan <adobriyan@...il.com>,
        "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...nel.org" <mingo@...nel.org>,
        "jpoimboe@...hat.com" <jpoimboe@...hat.com>,
        "luto@...nel.org" <luto@...nel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "brgerst@...il.com" <brgerst@...il.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dvlasenk@...hat.com" <dvlasenk@...hat.com>,
        "h.peter.anvin@...el.com" <h.peter.anvin@...el.com>,
        linux-tip-commits <linux-tip-commits@...r.kernel.org>
Subject: RE: [tip:x86/pti] x86/asm: Pad assembly functions with INT3
 instructions

From: Mike Galbraith
> Sent: 17 June 2018 14:39
...
> > > Is dinky patchlet suggesting cryptomgr is being naughty?
...
> > diff --git a/arch/x86/crypto/aegis128-aesni-asm.S b/arch/x86/crypto/aegis128-aesni-asm.S
> > index 9254e0b6cc06..717bf0776421 100644
> > --- a/arch/x86/crypto/aegis128-aesni-asm.S
> > +++ b/arch/x86/crypto/aegis128-aesni-asm.S
> > @@ -535,6 +535,7 @@ ENTRY(crypto_aegis128_aesni_enc_tail)
> >  	movdqu STATE3, 0x40(STATEP)
> >
> >  	FRAME_END
> > +	ret
> >  ENDPROC(crypto_aegis128_aesni_enc_tail)
...

How much of the rest of the associated crypyo changes were actually tested?
I can't image the code DTRT without the 'ret'.

	David