linux-kernel - Re: [PATCH] misc: ocxl: Change return type for fault handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wouvvsqz.fsf@concordia.ellerman.id.au>
Date:   Tue, 19 Jun 2018 22:57:24 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Souptick Joarder <jrdr.linux@...il.com>,
        Frederic Barrat <fbarrat@...ux.ibm.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Sabyasachi Gupta <sabyasachi.linux@...il.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, fbarrat@...ux.vnet.ibm.com,
        Matthew Wilcox <willy@...radead.org>,
        Andrew Donnellan <andrew.donnellan@....ibm.com>,
        brajeswar.linux@...il.com, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] misc: ocxl: Change return type for fault handler

Souptick Joarder <jrdr.linux@...il.com> writes:
> On Thu, Jun 14, 2018 at 9:36 PM, Frederic Barrat <fbarrat@...ux.ibm.com> wrote:
>> Le 11/06/2018 à 22:29, Souptick Joarder a écrit :
>>>
>>> Use new return type vm_fault_t for fault handler. For
>>> now, this is just documenting that the function returns
>>> a VM_FAULT value rather than an errno. Once all instances
>>> are converted, vm_fault_t will become a distinct type.
>>>
>>> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>>>
>>> There is an existing bug when vm_insert_pfn() can return
>>> ENOMEM which was ignored and VM_FAULT_NOPAGE returned as
>>> default. The new inline vmf_insert_pfn() has removed
>>> this inefficiency by returning correct vm_fault_ type.
>>>
>>> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
>>> ---
>>
>>
>> Thanks!
>>
>> Tested and
>> Acked-by: Frederic Barrat <fbarrat@...ux.vnet.ibm.com>
>
> Frederic, is this patch queued for 4.19 ?

Not yet, you're a bit early. 4.18-rc1 only came out the other day :)

Your patches are tracked here:

  http://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=67924


They should appear in 4.19 unless something conflicts with them.

cheers