linux-kernel - Re: [PATCH v2 0/2] Detect & register virtio-crypto algos only if it can be supported by backend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jun 2018 16:08:05 +0200
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Farhan Ali <alifm@...ux.ibm.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     mst@...hat.com, qemu-devel@...gnu.org, arei.gonglei@...wei.com,
        longpeng2@...wei.com, pasic@...ux.ibm.com, frankja@...ux.ibm.com,
        Jason Wang <jasowang@...hat.com>,
        Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH v2 0/2] Detect & register virtio-crypto algos only if it
 can be supported by backend

On 06/19/2018 03:26 PM, Farhan Ali wrote:
> A polite ping :)
> 
> If no one has any more comments/feedback then I would like to how to merge these patches to the mainline kernel tree.

I think it should go via Michael Tsirkin or Jason Wang (Adding Jason).
Also adding Herbert Xu as FYI.


I have not looked into the details of the patch, but I like the idea.
Acked-by: Christian Borntraeger <borntraeger@...ibm.com>



> 
> Thanks
> Farhan
> 
> On 06/13/2018 04:38 PM, Farhan Ali wrote:
>> Hi,
>>
>> Currently the Linux virtio-crypto driver registers the crypto
>> algorithm without verifying if the backend actually supports the
>> algorithm.
>>
>> This kernel patch series adds support for registering algorithm
>> with Linux crypto layer, only if the algorithm is supported by
>> the backend device. This also makes the driver more compliant with
>> the virtio-crypto spec [1].
>>
>> I would appreciate any feedback or comments on this.
>>
>> Thank you
>> Farhan
>>
>> Reference
>> ---------
>> [1] Virtio crypto spec proposal https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00816.html
>>
>> ChangeLog
>> ---------
>> v1 -> v2
>>     - Modify comment as suggested by Arei (patch 1)
>>     - Modify error message as suggested by Arei (patch 2)
>>
>>
>> Farhan Ali (2):
>>    crypto/virtio-crypto: Read crypto services and algorithm masks
>>    crypto/virtio-crypto: Register an algo only if it's supported
>>
>>   drivers/crypto/virtio/virtio_crypto_algs.c   | 112 ++++++++++++++++++---------
>>   drivers/crypto/virtio/virtio_crypto_common.h |  25 +++++-
>>   drivers/crypto/virtio/virtio_crypto_core.c   |  29 +++++++
>>   drivers/crypto/virtio/virtio_crypto_mgr.c    |  81 +++++++++++++++++--
>>   4 files changed, 202 insertions(+), 45 deletions(-)
>>
>