linux-kernel - Re: [PATCH] crypto: skcipher: remove static declaration of export function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180619142727.7kvtuimjufvdacqn@gondor.apana.org.au>
Date:   Tue, 19 Jun 2018 22:27:28 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     efremov@...ux.com, "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH] crypto: skcipher: remove static declaration of export
 function

On Mon, Jun 18, 2018 at 10:28:03AM -0700, Eric Biggers wrote:
> On Sun, Jun 17, 2018 at 08:49:59PM +0300, efremov@...ux.com wrote:
> > The function skcipher_walk_next declared as static and marked as
> > EXPORT_SYMBOL. It's a bit confusing since export symbol means that
> > we want others to use this function. The area of visibility for such
> > function is its .c file and all other modules. Other *.c files of the
> > same module can't use it, despite all other modules can. Relying on
> > that such behavior was not the original intention, the patch just
> > removes the static keyword.
> > 
> > Found by Linux Driver Verification project (linuxtesting.org).
> > 
> > Signed-off-by: Denis Efremov <efremov@...ux.com>
> 
> Why not remove the EXPORT_SYMBOL instead?  It has no users outside the file.

I agree.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt