linux-kernel - Re: [PATCH 1/2] cifs: use timespec64 internally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8736xibunk.fsf@paulo.ac>
Date:   Tue, 19 Jun 2018 13:36:31 -0300
From:   Paulo Alcantara <paulo@...lo.ac>
To:     Arnd Bergmann <arnd@...db.de>, Steve French <sfrench@...ba.org>
Cc:     y2038@...ts.linaro.org, Arnd Bergmann <arnd@...db.de>,
        Aurelien Aptel <aaptel@...e.com>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Pavel Shilovsky <pshilov@...rosoft.com>,
        Long Li <longli@...rosoft.com>,
        Kees Cook <keescook@...omium.org>, linux-cifs@...r.kernel.org,
        samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] cifs: use timespec64 internally

Arnd Bergmann <arnd@...db.de> writes:

> In cifs, the timestamps are stored in memory in the cifs_fattr structure,
> which uses the deprecated 'timespec' structure. Now that the VFS code
> has moved on to 'timespec64', the next step is to change over the fattr
> as well.
>
> This also makes 32-bit and 64-bit systems behave the same way, and
> no longer overflow the 32-bit time_t in year 2038.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  fs/cifs/cifsencrypt.c |  4 ++--
>  fs/cifs/cifsglob.h    |  6 +++---
>  fs/cifs/cifsproto.h   |  6 +++---
>  fs/cifs/cifssmb.c     | 12 ++++++------
>  fs/cifs/inode.c       | 34 ++++++++++++++++------------------
>  fs/cifs/netmisc.c     | 19 ++++++++++---------
>  6 files changed, 40 insertions(+), 41 deletions(-)

Reviewed-by: Paulo Alcantara <palcantara@...e.de>

Thanks
Paulo