linux-kernel - Re: [PATCH v6 1/3] USB host: Add USB ehci support for nuvoton npcm7xx platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKKbWA79=k-HEinMNNw7y8bCg2s2M+_S8uFDuR-sQz7A7zFSPg@mail.gmail.com>
Date:   Tue, 19 Jun 2018 20:47:54 +0300
From:   Avi Fishman <avifishman70@...il.com>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Tomer Maimon <tmaimon77@...il.com>,
        Patrick Venture <venture@...gle.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        mathias.nyman@...ux.intel.com, bjorn.andersson@...aro.org,
        jhogan@...nel.org, albeu@...e.fr, chunfeng.yun@...iatek.com,
        Tony Lindgren <tony@...mide.com>, baolu.lu@...ux.intel.com,
        Alex Elder <elder@...aro.org>,
        Dmitry Osipenko <digetx@...il.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        hdegoede@...hat.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-usb@...r.kernel.org,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>
Subject: Re: [PATCH v6 1/3] USB host: Add USB ehci support for nuvoton npcm7xx platform

On Tue, Jun 19, 2018 at 5:49 PM Alan Stern <stern@...land.harvard.edu> wrote:
>
> On Tue, 19 Jun 2018 avifishman70@...il.com wrote:
>
> > From: Avi Fishman <AviFishman70@...il.com>
> >
> > This patch adds support for ehci controller for the Nuvoton
> > npcm7xx platform.
> > Most of the code was taken from ehci-spear.c + specific initialization
> > code
> >
> > Signed-off-by: Avi Fishman <AviFishman70@...il.com>
> > ---
> >  drivers/usb/host/Kconfig        |   8 ++
> >  drivers/usb/host/Makefile       |   1 +
> >  drivers/usb/host/ehci-npcm7xx.c | 212 ++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 221 insertions(+)
> >  create mode 100644 drivers/usb/host/ehci-npcm7xx.c
> >
> > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> > index 9f0aeb068acb..e3100b249f0f 100644
> > --- a/drivers/usb/host/Kconfig
> > +++ b/drivers/usb/host/Kconfig
> > @@ -185,6 +185,14 @@ config USB_EHCI_MXC
> >       ---help---
> >         Variation of ARC USB block used in some Freescale chips.
> >
> > +config USB_EHCI_HCD_NPCM7XX
> > +     tristate "Support for Nuvoton NPCM7XX on-chip EHCI USB controller"
> > +     depends on (USB_EHCI_HCD && ARCH_NPCM7XX) || COMPILE_TEST
> > +     default y
>
> Are you sure this is what you want?  The value defaults to Y whenever
> COMPILE_TEST is enabled?  Will that annoy people doing compile tests?
>

Do you recomment to change to:
default y if (USB_EHCI_HCD && ARCH_NPCM7XX)

> Aside from that one issue,
>
> Acked-by: Alan Stern <stern@...land.harvard.edu>
>
> Alan Stern
>